Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PGML.pl has lines that should have been removed. #1005

Closed
dpvc opened this issue Feb 6, 2024 · 1 comment
Closed

PGML.pl has lines that should have been removed. #1005

dpvc opened this issue Feb 6, 2024 · 1 comment

Comments

@dpvc
Copy link
Member

dpvc commented Feb 6, 2024

The lines

pg/macros/core/PGML.pl

Lines 942 to 945 in 832cb29

if ($block->{type} eq 'math' && Value::isValue($result)) {
if ($block->{parsed}) { $result = $result->string }
else { $result = '{' . $result->TeX . '}' }
}

should have been removed when

pg/macros/core/PGML.pl

Lines 946 to 948 in 832cb29

if (Value::isValue($result)) {
$result = ($block->{type} eq 'math' && !$block->{parsed} ? '{' . $result->TeX . '}' : $result->string);
}

where added in #981. It looks like the changes from my suggestions that removed those lines didn't make it into the actual PR.

@pstaabp
Copy link
Member

pstaabp commented Feb 7, 2024

fixed in #1006

@pstaabp pstaabp closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants