Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure appropriate granularity of tests #184

Closed
1 of 2 tasks
gsarma opened this issue Jul 7, 2015 · 2 comments
Closed
1 of 2 tasks

Ensure appropriate granularity of tests #184

gsarma opened this issue Jul 7, 2015 · 2 comments

Comments

@gsarma
Copy link
Member

gsarma commented Jul 7, 2015

Discussion with @travs:
In some cases, we have a single test that verifies an entire class of behavior. For example, in the evidence quality tests that we just added, we verify wholesale that every fact has a doi or url. This means that in the event that there is a failure, the user will have to interactively determine where exactly the failure is- the test won't reveal that information.

We should review all of the tests at some point and make sure they are appropriately granular for the sake of making debugging easier. One way to do this would be to use generating tests:

http://nose.readthedocs.org/en/latest/writing_tests.html#test-generators

  • Provide adequate reporting of the cause for failures in reporting of DOI / URL presence in Evidence
  • Others?
@travs travs added this to the Generic testing milestone milestone Jul 9, 2015
@mwatts15
Copy link
Contributor

This task needs to be broken down into a list of which tests need to be decomposed and how.

@mwatts15 mwatts15 added the sp/20 label Mar 16, 2019
@mwatts15
Copy link
Contributor

It's hard to do this as one self-contained task. Developers should keep in mind how to write good tests that explain themselves, but that's ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants