Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] The k8s version problem involved in yurtadm join #908

Closed
windydayc opened this issue Jul 14, 2022 · 6 comments
Closed
Labels
kind/feature kind/feature

Comments

@windydayc
Copy link
Member

windydayc commented Jul 14, 2022

When using yurtadm join , the kubeadm, kubelet will be downloaded from here, and their versions will be the same as the installed kubernetes version.

However, in preflight phase, it will check kubelet version, but here the kubelet version is restricted to be above 1.21.0, that is to say, if you want to use yurtadm join, the k8s version must be above 1.21.0.

There is currently a need for a way to solve this problem.

others
/kind feature

@windydayc windydayc added the kind/feature kind/feature label Jul 14, 2022
@windydayc
Copy link
Member Author

@rambohe-ch
Copy link
Member

@windydayc how about post a pull request to fix this problem at first? maybe we can define MinimumKubeletVersion to v1.18.0

@windydayc
Copy link
Member Author

windydayc commented Jul 14, 2022

@windydayc how about post a pull request to fix this problem at first? maybe we can define MinimumKubeletVersion to v1.18.0

@rambohe-ch

The code in pkg/util/kubernetes/kubeadm is copied from the kubeadm v1.22.3 source code, from #864.

Is it feasible to directly modify the imported kubeadm source code in this way?

@rambohe-ch
Copy link
Member

@windydayc how about post a pull request to fix this problem at first? maybe we can define MinimumKubeletVersion to v1.18.0

@rambohe-ch

The code in pkg/util/kubernetes/kubeadm is copied from the kubeadm v1.22.3 source code, from #864.

Is it feasible to directly modify the imported kubeadm source code in this way?

@windydayc yurtadm join should be used for K8s from v1.18+, so it's need to adjust it. Do you have any other solutions?

@windydayc
Copy link
Member Author

@windydayc how about post a pull request to fix this problem at first? maybe we can define MinimumKubeletVersion to v1.18.0

@rambohe-ch
The code in pkg/util/kubernetes/kubeadm is copied from the kubeadm v1.22.3 source code, from #864.
Is it feasible to directly modify the imported kubeadm source code in this way?

@windydayc yurtadm join should be used for K8s from v1.18+, so it's need to adjust it. Do you have any other solutions?

OK. I haven't thought of another solution yet.

@windydayc
Copy link
Member Author

windydayc commented Aug 11, 2022

already solved in #964

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

No branches or pull requests

2 participants