Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paulgraham.com #1143

Open
Popolechien opened this issue Aug 23, 2024 · 9 comments
Open

paulgraham.com #1143

Popolechien opened this issue Aug 23, 2024 · 9 comments
Assignees
Labels
Bug Something isn't working Zimit

Comments

@Popolechien
Copy link
Collaborator

@RavanJAltaie
Copy link
Contributor

Recipe created
https://farm.openzim.org/recipes/paulgraham.com_en_all
I'll update the library link once ready

@benoit74
Copy link
Contributor

benoit74 commented Sep 2, 2024

From @RavanJAltaie in wrong issue

https://dev.library.kiwix.org/viewer#paulgraham.com_en_all_2024-08
The file is not complete, I've tried to change the scope type but same result.
Could you please check? @benoit74

@benoit74 benoit74 self-assigned this Sep 2, 2024
@benoit74 benoit74 added Bug Something isn't working Zimit labels Sep 2, 2024
@RavanJAltaie
Copy link
Contributor

@benoit74 thanks for fixing the position of the comment @benoit74

@RavanJAltaie
Copy link
Contributor

@benoit74 Yet any comment for the incomplete file?

@benoit74
Copy link
Contributor

Sorry, looks like I forgot this issue after moving it.

Could you be more specific in what is missing? I don't see anything missing.

I however see two serious flaws:

  • there is a constantly annoying popup saying "No store-id passed to the loader script" everytime we load a new page. Do you see it as well or am I the only one? This is going to be hard and fragile to fix AFAIK.
  • the UI feels weird on desktops because it is optimized for small mobile screens and does not adapt dynamically ... I don't know if we really want to fix this ... if we switch to something optimized for desktops, then the look and feel will be weird / ugly on mobile screens. @kelson42 @Popolechien do you have any recommendation on this kind of situation? Should we create two ZIMs, one for desktop screens and one for mobile screens?

@Popolechien
Copy link
Collaborator Author

Well our policy for Wikimedia content is to aim for mobile (though I'm not sure what you mean by "small mobile"), so I'd focus on that one. But tbh I don't understand how it can display fine on a desktop browser and not so much on Kiwix-server.
Screenshot 2024-09-17 at 09 16 37
Screenshot 2024-09-17 at 09 17 10

I also get the annoying popup btw.

@benoit74
Copy link
Contributor

But tbh I don't understand how it can display fine on a desktop browser and not so much on Kiwix-server.

You are probably not at same page resolution and/or you did not reloaded the page. And this does not look at all like a mobile screen resolution (you should aim for something like ~400px).

Let's showcase it with a video:

Screen.Recording.2024-09-17.at.09.54.19.mov

At the beginning of the video, I show the website on a desktop screen. This is perfectly readable.

Then I switch to a mobile screen. This is not readable at all. This is what would happen on mobile phones if we capture this desktop version.

Then I reload the page with still this mobile screen. The UI is completely updated to be readable on a mobile screen.

Then I switch to a desktop screen. This looks exactly like currently inside the ZIM when opened on a desktop screen.

@Popolechien
Copy link
Collaborator Author

Ok two things here:

  • What kind of god-forsaken backend is that guy using that renders so poorly (no offense, but hey)?
  • What about the shopping cart being only viewable on desktop?

@benoit74
Copy link
Contributor

¯\_(ツ)_/¯

See FAQ - especially last question - to get a better grasp on who Paul Graham is ^^

I don't expect experts in Lisp and other esotheric languages to share my views on many things. Not saying any of us is right or wrong, or that we cannot work together, we just have different understanding of the world ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Zimit
Projects
None yet
Development

No branches or pull requests

3 participants