Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors thrown by zipkin bubbles all the way to the top #424

Open
russell-matt opened this issue Jul 25, 2019 · 2 comments
Open

Errors thrown by zipkin bubbles all the way to the top #424

russell-matt opened this issue Jul 25, 2019 · 2 comments

Comments

@russell-matt
Copy link
Contributor

When using zipkin-instrumentation-restify, an error that was being thrown in zipkin bubbled up all the way to the top, and out of the middleware, which causes the server to crash.

The error should be handled gracefully and not cause errors to be thrown out of the middleware.

This issue was also raised in #422 (direct quote link)

@codefromthecrypt
Copy link
Member

codefromthecrypt commented Jul 25, 2019

ack. this would impact any middleware. There's a slight problem which is that we are writing bug guards and the bug guards could have bugs.

anyway we can try to figure a way to best effort some protection assuming express restify etc don't already have a middleware guard

@jcchavezs
Copy link
Contributor

@russell-matt any chance you can scratch a failing test for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants