Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: RelatedImages #1069

Merged
merged 3 commits into from
Oct 16, 2019

Conversation

ecordell
Copy link
Member

Description of the change:
This is a resurrection of #946

Motivation for the change:
We need to be able to identify related images for mirroring into disconnected environments.

@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2019
@ecordell ecordell changed the title Relatedimages proposal Proposal: RelatedImages Oct 10, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 10, 2019
@openshift-ci-robot
Copy link
Collaborator

@ecordell: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-olm 840a709 link /test e2e-aws-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@alecmerdler alecmerdler removed their request for review October 11, 2019 05:19
@ecordell
Copy link
Member Author

Verbal approval from @shawn-hurley and I want to reference this doc, so merging now and if we need to change something we can make a new PR.

@ecordell ecordell merged commit 4edf102 into operator-framework:master Oct 16, 2019
@rcernich
Copy link

Not sure how to comment on the proposal, so adding my two cents here...

Would it be better to put this information into a separate file in the metadata bundle? I think this would be a simpler solution than modifying the csv file every time an image used within it is rebuilt.

@AndrienkoAleksandr
Copy link

Hello, @ecordell . Sorry, was this proposal implemented about olm.relatedImage in the annotation? I see it was marked like future work...

@AndrienkoAleksandr
Copy link

AndrienkoAleksandr commented Jun 3, 2020

@ecordell 840a709#diff-4ada87752d32e1f3f585474c722d2633R44 we have short digest, because annotation has limitation in 63 characters and such long image can't be applied: docker.io/eclipse/che-theia-endpoint-runtime-binary@sha256:14041e6e51f47248e1018a2dacc8e70acad08f2a2dd7dc67c83a1b43d2cb73b7 in a full form?

anik120 added a commit to anik120/operator-lifecycle-manager that referenced this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants