Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed export GO111MODULE=on from all places since it shows no longer required in 1.13 #2182

Closed
camilamacedo86 opened this issue Nov 12, 2019 · 4 comments
Closed

Removed export GO111MODULE=on from all places since it shows no longer required in 1.13 #2182

camilamacedo86 opened this issue Nov 12, 2019 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Contributor

Feature Request

Removed export GO111MODULE=on from all places since it shows no longer required in 1.13
@camilamacedo86 camilamacedo86 added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Nov 12, 2019
@camilamacedo86 camilamacedo86 mentioned this issue Nov 12, 2019
Merged
@joelanford
Copy link
Member

@camilamacedo86 this was already completed in #2135

@camilamacedo86
Copy link
Contributor Author

But it shows that still needed @joelanford : https://github.com/operator-framework/operator-sdk/search?q=GO111MODULE&unscoped_q=GO111MODULE

Or, is correct the SDK output the following error when it is off?

$ operator-sdk generate k8s
FATA[0000] using go modules requires GO111MODULE="on", "auto", or unset. More info: https://github.com/operator-framework/operator-sdk/blob/master/doc/user-guide.md#go-modules

@joelanford
Copy link
Member

Correct. If you look closely, you'll see that those usages are there to ensure that a user's GO111MODULE environment variable is setup correctly.

GO111MODULE is required to be setup correctly. However in Go 1.13, the default behavior when it is unset or auto has changed. See golang/go#31857 for details.

@camilamacedo86
Copy link
Contributor Author

Closing it. You are right if we do not set it, that's the same as auto.
Has no need for this task all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joelanford @camilamacedo86