Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-submit checks file for the project #637

Closed
5 tasks done
rt4914 opened this issue Feb 4, 2020 · 7 comments
Closed
5 tasks done

Add pre-submit checks file for the project #637

rt4914 opened this issue Feb 4, 2020 · 7 comments
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Feb 4, 2020 •
edited by BenHenning
Loading

Oppia-Android should have pre-submit checks file similar to the web so that while making a push the file will run all the test cases, check the PR guidelines which will ensure that PRs are working in terms on test cases.
@anandwana001
Copy link
Contributor

Reference of Oppia-web: here

@BenHenning BenHenning added this to the Beta milestone Jun 23, 2020
@anandwana001 anandwana001 mentioned this issue Oct 6, 2020
Closed
4 tasks
@anandwana001
Copy link
Contributor

anandwana001 commented Nov 17, 2020 •
edited
Loading

@rt4914 This could be a good tracker issue,

@anandwana001 anandwana001 self-assigned this Jan 12, 2021
@Sparsh1212
Copy link
Contributor

@anandwana001 I would like to work on the pre-submit checks for the XML files. Please assign this to me if possible and also, your guidance on how to get started on this will be much help. Thanks!

@anandwana001
Copy link
Contributor

anandwana001 commented Mar 12, 2021 •
edited
Loading

@Sparsh1212 PTAL #970
and let me know if you want to work on this, it's a separate issue for this XML one mentioned in this issue.

The tricky part is we have to lint XML file without using Gradle.

@Sparsh1212
Copy link
Contributor

Sparsh1212 commented Mar 12, 2021 •
edited
Loading

@Sparsh1212 PTAL #970
and let me know if you want to work on this, it's a separate issue for this XML one mentioned in this issue.

The tricky part is we have to lint XML file without using Gradle.

Yes, I would like to work on this. Please guide me on how to approach this. Any references or anything will be of great help to me. Also, I had a look at the discussion on #970, but I see, that no conclusion was made regarding the finalization of the approach. Please clear that too.
Thanks!

@anandwana001 anandwana001 removed their assignment Mar 30, 2021
@anandwana001
Copy link
Contributor

unassigning myself as this might cover under GSoC this year.

@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer and removed good second issue Impact: Low Low perceived user impact (e.g. edge cases). labels Sep 14, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip added enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@MohitGupta121 MohitGupta121 added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 8, 2023
@BenHenning
Copy link
Member

I think we've addressed basically all of the original goals of this issue, except maybe XML (though it's partially verified in static_checks.sh:

oppia-android/scripts/static_checks.sh

Line 58 in 0ef7a46

bazel run //scripts:xml_syntax_check -- $(pwd)

I think, overall, we can consider the presubmit checks completed for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@rt4914 @seanlip @BenHenning @anandwana001 @Sparsh1212 @MohitGupta121 @Broppia