Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing sudo calls to busser #122

Merged
merged 1 commit into from
May 24, 2013
Merged

Adding missing sudo calls to busser #122

merged 1 commit into from
May 24, 2013

Conversation

adamhjk
Copy link
Contributor

@adamhjk adamhjk commented May 23, 2013

When running with a strict umask (0027 or 0077) busser failed to
work, because parts of the pipeline were not actually being run
as root. This patch fixes that. :)

Also - super clever base64 test injection hack. Why not re-use your SCP stuff to a temp directory, though, and simply move them into place?

When running with a strict umask (0027 or 0077) busser failed to
work, because parts of the pipeline were not actually being run
as root. This patch fixes that. :)
@fnichol
Copy link
Contributor

fnichol commented May 24, 2013

Oh you found this little nasty…

The initial goal (a long time ago) was to try and transfer the testing files and issue the busser test command within 1 SSH session to avoid those reverse DNS/SSH slowdowns that can happen.

Since then I've been wondering if net/scp can use an open net/ssh channel to transfer the files before the command is issued. Think that's possible? Getting rid of this code eliminates the line count (and complexity) in this project and busser.

As an aside, Ruby's standard library is great for allowing you to do these crazy things with no further dependencies 😸

fnichol added a commit that referenced this pull request May 24, 2013
Adding missing sudo calls to busser
@fnichol fnichol merged commit 11e7a7e into master May 24, 2013
@fnichol fnichol deleted the busser_sudo_fix branch May 24, 2013 20:27
@test-kitchen test-kitchen locked and limited conversation to collaborators Nov 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants