CLI refactoring to remove logic from cli.rb #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnichol
added a commit
that referenced
this pull request
Dec 23, 2013
CLI refactoring to remove logic from cli.rb
|
+1 Less Thor! |
BrentOnRails
pushed a commit
to BrentOnRails/test-kitchen
that referenced
this pull request
Jul 17, 2017
Updated readme based on issue 300
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to remove as much non-Thor code as possible leaving the door open to non-Thor options, allowing other tooling to reuse commands, allow for better command unit testing, etc.
While the line count actually increased, it is my hope the ultimately readability and separation of concerns wins out here.