[Breaking] Modify ShellOut#run_command to take an options Hash. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users of the method to pass additional configuration to the shelled out command such as environment variables, current working director, customized timeout value, etc. This mixin module (Kitchen::ShellOut) is used internally and exposed to Driver implementors as `#run_command` in all `Driver::Base` subclasses.
fnichol
added a commit
that referenced
this pull request
Mar 23, 2013
[Breaking] Modify ShellOut#run_command to take an options Hash.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users of the method to pass additional configuration to
the shelled out command such as environment variables, current working
director, customized timeout value, etc.
This mixin module (Kitchen::ShellOut) is used internally and exposed to
Driver implementors as
#run_commandin allDriver::Basesubclasses.