New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In case of errors - write log & throw an exception #7

Open

ihor-sviziev opened this issue May 11, 2017 · 0 comments

Contributor

ihor-sviziev commented May 11, 2017 •

edited

Loading

Right now if I put incorrect credentials - nobody will know that emails aren't sent. In case of errors need throw an exception like this: https://github.com/magepal/magento2-gmailsmtpapp/blob/master/Model/Transport.php#L43

Note: Right now we don't have any exception if there returned incorrect status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment