Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More short profiles be pulled form shuyo/language-detection #57

Open
thekalinga opened this issue Jun 21, 2016 · 4 comments
Open

More short profiles be pulled form shuyo/language-detection #57

thekalinga opened this issue Jun 21, 2016 · 4 comments

Comments

@thekalinga
Copy link

I see that original project has a lot more short profiles than this project. Is it possible for you do upload these short files from the original project into this?

Original:
https://github.com/shuyo/language-detection/tree/master/profiles.sm

This project:
https://github.com/optimaize/language-detector/tree/master/src/main/resources/languages.shorttext

@fabiankessler
Copy link
Contributor

License is Apache License 2.0, so yes it's possible. If you or someone creates a pull request with some tests I'll merge it.

@idanh
Copy link

idanh commented Nov 28, 2016

+1
Someone already forked your project and added those in 2 simple commits:
fork: https://github.com/eclectice/language-detector/commits/master

commit 1: eclectice@467e52f
commit 2: eclectice@7b70804

without the gradle nonsense there, I think that's all you need no?
Could you please add those as well? I'd love to use them!

@wikier
Copy link

wikier commented Feb 7, 2017

Is it going to merged back at any point?

@predictron-cloud
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants