Fix precedence for explicit sys prop and env var sources. #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomas-langer Note the comments in the tests that say "Implicit sources always take precedence"; this strikes me as wrong/backwards, but I'm assuming fixing it would be a breaking change. |
tomas-langer
reviewed
Sep 7, 2019
| String qualifiedName = "[" + name + "]"; | ||
| for (ConfigSource source : sources) { | ||
| if (source instanceof MapConfigSource | ||
| && source.description().contains(qualifiedName)) { |
There was a problem hiding this comment.
If we rely on a description, you should also update the place the description is created to make sure it is not changed.
I would prefer a more deterministic way of finding these sources out - maybe wrapping them in a specific class (EnvVarConfigSource and SysPropConfigSource or similar) and looking for these types.
There was a problem hiding this comment.
Yes, agreed, this is a little fragile; I'm just about to lose internet for a couple of days, so will deal with this next week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977.