-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Application poms #1022
Application poms #1022
Conversation
…lications. Update webserver examples to use the new applications parent pom. Updated the opentracing example to align the docker build with the quickstart. Updated the translator application: - multi-stage docker build - converted to pure SE (replaced usage of jersey with webserver) - removed hooks to simulate resiliency - removed TODOs for security - removed useless static HTML - refactored both frontend and backend under a single directory with a common reactor and common README.md - reworked README.md - added proper k8s yaml to run the app on docker-for-desktop
- use webpack for bundling javascript on the frontend - update the dockerfiles - udpate README.me Add a top level k8s directory with zipkin and ingress resources.
…mment-aas to document tryout steps
Update integrations/cdi examples Tested oci-objectstorage and jedis. Fixed an issue in oci-objectstorage integration with empty passphrase.
helidon-parent -> helidon-bom -> helidon-3rdparty -> helidon-project -> applications-project The BOM pom is now inherited by helidon-project, thus the requirement of ${project.version} for Helidon modules is now dropped. This also helps enforcing that the BOM pom contains an entry for all modules. Using <relativePath>../../../applications/se/pom.xml</relativePath> in all examples in order to build locally with a single Maven reactor. This shall be refactored to <relativePath/> when the example are moved out of the main repository. It is a temporary trade-off.
Fix checkstyle Fix docs build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this a great deal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved if all tests pass including native-image
…ports last within 3rparty pom, add dep mgmt for openapi-tck
c03c8f1
…id conflicting with project.version on application poms since the bom is inherited
A couple of non critical changes are missing from this PR:
Both of these changes will be added directly in the release branch and merged to master post release. |
Application poms:
Create a new parent pom hierarchy to fit new applications-pom:
The BOM pom is now inherited by helidon-project, thus the requirement of ${project.version} for
Helidon modules is effectively dropped. This also helps enforcing that the BOM pom contains an entry
for all modules.
Update bare archetypes and all examples/apps to use the application-poms.
Using
<relativePath>../../../applications/se/pom.xml</relativePath>
in all examples in orderto build locally with a single Maven reactor. This shall be refactored to when
the example are moved out of the main repository. This is a temporary trade-off. Also Updated
the archetype creation script to replace relativePath to
<relativePath/>
.Example updates:
Metrics 2 changes
Simplified the Maven aspect of the metrics 2 support:
transitive dependency version is trumped.