Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tyrus server support for native-image in SE #2097

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

danielkec
Copy link
Contributor

This fixes Tyrus server, not the client

Fixes #1966

Signed-off-by: Daniel Kec daniel.kec@oracle.com

@danielkec danielkec self-assigned this Jun 25, 2020
@danielkec danielkec added native-image SE websocket WebSocket in Helidon labels Jun 25, 2020
@danielkec danielkec added this to the 2.0.1 milestone Jun 25, 2020
@danielkec danielkec added dependencies Pull requests that update a dependency file 2.x Issues for 2.x version branch labels Jun 25, 2020
@dansiviter
Copy link
Contributor

Would reflection-config.json need changing for #1934?

tomas-langer
tomas-langer previously approved these changes Aug 10, 2020
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec
Copy link
Contributor Author

Would reflection-config.json need changing for #1934?

@dansiviter Hard to say, I guess we will have to expand native image smoke test to find out

Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielkec danielkec merged commit 1824a3a into helidon-io:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch dependencies Pull requests that update a dependency file native-image SE websocket WebSocket in Helidon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tyrus support in GraalVM
3 participants