2592 Chunk leak #2605
Merged
2592 Chunk leak #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkec
force-pushed
the
2592-ByteBuffLeak
branch
2 times, most recently
from
6ebcde3
to
3d664f9
Compare
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
force-pushed
the
2592-ByteBuffLeak
branch
from
3d664f9
to
3a1de02
Compare
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
danielkec
force-pushed
the
2592-ByteBuffLeak
branch
from
3a1de02
to
4b6a804
Compare
ljnelson
reviewed
Dec 14, 2020
webserver/webserver/src/test/java/io/helidon/webserver/DataChunkReleaseTest.java
Show resolved
Hide resolved
ljnelson
requested changes
Dec 14, 2020
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
romain-grecourt
approved these changes
Dec 15, 2020
ljnelson
reviewed
Dec 15, 2020
| // look for ByteBufRequestChunk's leak detection records | ||
| if (record.getLevel() == Level.WARNING && | ||
| record.getMessage() | ||
| .startsWith("LEAK: RequestChunk.release() was not called before it was garbage collected.")) { |
There was a problem hiding this comment.
This one I assume needs to be the same as line 66?
There was a problem hiding this comment.
No its different check and it has its own message, They just happens to have very similar but not exactly same messages. I am tracking both to be extra safe
danielkec
added
P1
bug
|
@danielkec the new test seems to be failing intermittently, can you take a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2592