Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed query parameter check that is too strict. #2693

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Removed query parameter check that is too strict. #2693

merged 2 commits into from
Feb 11, 2021

Conversation

Tomas-Kraus
Copy link
Member

@Tomas-Kraus Tomas-Kraus commented Jan 26, 2021 •
edited
Loading

Fixes issue #2599

@Tomas-Kraus Tomas-Kraus added bug Something isn't working P3 DB client Helidon DB Client labels Jan 26, 2021
@Tomas-Kraus Tomas-Kraus self-assigned this Jan 26, 2021
@Tomas-Kraus Tomas-Kraus added P2 and removed P3 labels Jan 26, 2021
@Tomas-Kraus Tomas-Kraus linked an issue Jan 28, 2021 that may be closed by this pull request
JdbcStatement named parameters should be usable more than once in a statement #2599
Closed
tomas-langer
tomas-langer requested changes Jan 29, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this deserves a test that uses more than one named parameter, to make sure this issue is fixed.

@Tomas-Kraus Tomas-Kraus force-pushed the BUG_2599 branch 2 times, most recently from 5837a10 to 9bcfd2a Compare February 1, 2021 12:52
@Tomas-Kraus
Copy link
Member Author

Looks like we have ci/pr-head — test failures. I'll rebase it on the top of the master.

@Tomas-Kraus
Removed query parameter check that is too strict.
959b114 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@Tomas-Kraus
Added junit test for Issue helidon-io#2599 reproduction scenario.
5bfaf95 
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
@Tomas-Kraus Tomas-Kraus merged commit 66122de into helidon-io:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees

@Tomas-Kraus Tomas-Kraus

Labels
bug Something isn't working DB client Helidon DB Client P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JdbcStatement named parameters should be usable more than once in a statement
2 participants
@Tomas-Kraus @tomas-langer