-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cover todo app with tests #2784
Conversation
examples/todo-app/backend/src/test/resources/test-application.yaml
Outdated
Show resolved
Hide resolved
examples/todo-app/frontend/src/test/java/io/helidon/demo/todos/frontend/FrontendTest.java
Outdated
Show resolved
Hide resolved
@romain-grecourt could you please confirm if it is OK to add versions for example dependencies, or if these should be version managed in |
Need to double check with Joe, we should add them to dependencies/pom.xml only if we have an existing approval for them. At the very least we should declare properties for these versions to make it look cleaner. |
Hello @tvallin, there were some changes related to presence of slf4j libraries, and I think that is why the merge branch is failing. could you kindly fix this, I will review/merge as soon as the pipelines pass |
This requires a bit more work. working on this myself |
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@barchetta I have added a logback core dependency management to |
Resolves #2718
Signed-off-by: tvallin thibault.vallin@oracle.com