Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover todo app with tests #2784

Merged
merged 7 commits into from
Oct 7, 2021
Merged

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Feb 20, 2021

Resolves #2718

Signed-off-by: tvallin thibault.vallin@oracle.com

@tomas-langer
Copy link
Member

@romain-grecourt could you please confirm if it is OK to add versions for example dependencies, or if these should be version managed in dependencies/pom.xml.

@romain-grecourt
Copy link
Contributor

@romain-grecourt could you please confirm if it is OK to add versions for example dependencies, or if these should be version managed in dependencies/pom.xml.

Need to double check with Joe, we should add them to dependencies/pom.xml only if we have an existing approval for them. At the very least we should declare properties for these versions to make it look cleaner.

@tomas-langer tomas-langer added the dependencies Pull requests that update a dependency file label Jun 8, 2021
barchetta
barchetta previously approved these changes Jun 8, 2021
tomas-langer
tomas-langer previously approved these changes Jun 29, 2021
@tomas-langer tomas-langer dismissed stale reviews from barchetta and themself via 50cf617 October 6, 2021 10:43
tomas-langer
tomas-langer previously approved these changes Oct 6, 2021
@tomas-langer
Copy link
Member

Hello @tvallin, there were some changes related to presence of slf4j libraries, and I think that is why the merge branch is failing. could you kindly fix this, I will review/merge as soon as the pipelines pass

@tomas-langer
Copy link
Member

This requires a bit more work. working on this myself

tvallin and others added 7 commits October 7, 2021 12:42
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer
Copy link
Member

@barchetta I have added a logback core dependency management to dependencies. This is already part of logback-classic (a transitive dependency).
This version management is needed for Cassandra, which depends on both of these libraries explicitly (and we would end up with different versions of them)

@tomas-langer tomas-langer self-assigned this Oct 7, 2021
@romain-grecourt romain-grecourt merged commit b04f7d9 into helidon-io:master Oct 7, 2021
@tvallin tvallin deleted the todoApp branch April 4, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate end-to-end testing of the TODOS example
4 participants