Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide for Testing with JUnit5 #3005

Merged
merged 5 commits into from
Aug 24, 2021
Merged

Guide for Testing with JUnit5 #3005

merged 5 commits into from
Aug 24, 2021

Conversation

ljamen
Copy link
Contributor

@ljamen ljamen commented May 10, 2021 •
edited
Loading

Now ready for first review.

@ljamen ljamen added the docs label May 10, 2021
@ljamen ljamen requested a review from tomas-langer May 10, 2021 23:47
@ljamen ljamen self-assigned this May 10, 2021
@ljamen ljamen removed the request for review from tomas-langer May 10, 2021 23:47
@ljamen ljamen requested a review from tomas-langer May 12, 2021 14:10
@ljamen ljamen changed the title WIP - Guide for Testing with JUnit5 Guide for Testing with JUnit5 May 12, 2021
@ljamen ljamen marked this pull request as ready for review May 12, 2021 14:11
@ljamen
Copy link
Contributor Author

ljamen commented May 12, 2021

I did not want to duplicate what is already in the MP testing doc. This guide assumes the user has reviewed that doc and is ready for the 'hands-on' examples.

There may be other resources for the Summary. I added a couple that I thought could be useful.

@ljamen
Copy link
Contributor Author

ljamen commented May 12, 2021

From the blog article: A small bug crawled into our code base, and as a result the artifact needed for this article did not get deployed to maven central as part of 2.1.0 release. We are working on a fix!

Is this something we need to address or fix in this guide/doc?

@ljamen ljamen mentioned this pull request May 13, 2021
Closed
@ljamen ljamen requested review from dalexandrov and removed request for tomas-langer May 13, 2021 16:56
@ljamen ljamen requested a review from dalexandrov May 14, 2021 13:00
dalexandrov
dalexandrov previously approved these changes May 25, 2021
View reviewed changes
@ljamen ljamen requested a review from tomas-langer June 3, 2021 15:48
tomas-langer
tomas-langer requested changes Jun 4, 2021
View reviewed changes
docs/mp/guides/38_testing_junit5.adoc Show resolved Hide resolved
docs/mp/guides/38_testing_junit5.adoc Outdated Show resolved Hide resolved
docs/mp/guides/38_testing_junit5.adoc Outdated Show resolved Hide resolved
tomas-langer
tomas-langer reviewed Aug 17, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the version of JUnit, which I think does not need to be defined, the guide is really nice! Also specifying a version would require constant updates to the guide when a version is changed (which is easy to be missed).

In current version of Helidon, we use JUnit version 5.7.0.

tomas-langer
tomas-langer approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romain-grecourt romain-grecourt merged commit 270e1a1 into helidon-io:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

@dalexandrov dalexandrov Awaiting requested review from dalexandrov

Assignees

@ljamen ljamen

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljamen @dalexandrov @tomas-langer @romain-grecourt