Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds integrations for pseudo-XA datasources #3089

Merged
merged 12 commits into from
Oct 15, 2021

Conversation

ljnelson
Copy link
Member

@ljnelson ljnelson commented Jun 9, 2021

Signed-off-by: Laird Nelson laird.nelson@oracle.com

@ljnelson ljnelson added enhancement New feature or request P3 jpa/jta 2.x Issues for 2.x version branch labels Jun 9, 2021
@ljnelson ljnelson self-assigned this Jun 9, 2021
@ljnelson ljnelson linked an issue Jun 9, 2021 that may be closed by this pull request
@ljnelson ljnelson mentioned this pull request Jun 9, 2021
8 tasks
@ljnelson
Copy link
Member Author

ljnelson commented Jun 9, 2021

In general, this PR moves some package-private classes out of the JPA integration area and into their own projects, since these constructs have nothing to do with JPA. Some of these constructs look to be extremely useful for unit testing, which is the focus of #3008 with which this PR is associated.

I haven't changed any logic along the way (although obviously look out for boneheaded mistakes). I've taken advantage of the making-public by adding documentation and removing crufty methods and such.

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
barchetta
barchetta previously approved these changes Oct 12, 2021
@ljnelson
Copy link
Member Author

Just noticed the empty module-info.java file. Let me check and fix that. Interesting that it is valid.

…correcting description in integrations/jdbc/pom.xml

Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
@ljnelson ljnelson merged commit b68ef5b into helidon-io:master Oct 15, 2021
@ljnelson ljnelson deleted the datasource-jta branch October 15, 2021 17:21
dalexandrov pushed a commit to dalexandrov/helidon that referenced this pull request Oct 21, 2021
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issues for 2.x version branch enhancement New feature or request jpa/jta P3
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Make pseudo-JTA driver support stand alone
2 participants