Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation SE : Webclient guide #3189

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Jul 14, 2021

No description provided.

Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at possible changes here. :-)

docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Copy link
Member Author

tvallin commented Oct 8, 2021

@Verdent thanks for your review, I applied the required changes.

Verdent
Verdent previously approved these changes Nov 4, 2021
Copy link
Member

@Verdent Verdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Verdent Verdent requested a review from ljamen November 8, 2021 21:08
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you have any questions about my comments.

docs/se/guides/40_webclient.adoc Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
docs/se/guides/40_webclient.adoc Outdated Show resolved Hide resolved
Signed-off-by: tvallin <thibault.vallin@oracle.com>
@tvallin
Copy link
Member Author

tvallin commented Nov 16, 2021

Thank you @ljamen, I applied the changes.

@Verdent Verdent merged commit 81b13a4 into helidon-io:master Nov 16, 2021
@tvallin tvallin deleted the webclient_guide branch November 16, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants