Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check for OCI vaults #3299

Merged
merged 5 commits into from
Aug 26, 2021
Merged

Conversation

spericas
Copy link
Member

@spericas spericas commented Aug 19, 2021

Support for SE and MP. MP support can be enabled by simply including the dependency in your classpath and controlled by the oci.vault.vault-ocid property (only a single vault is supported in this case). SE support requires creating and registering an instance of HealthSupport with the liveness check.

Sample output:

  "outcome": "UP",
  "status": "UP",
  "checks": [
    {
      "name": "vault",
      "state": "UP",
      "status": "UP",
      "data": {
        "compartmentId": "ocid1.tenancy.oc1..aaaaaaaa3mdlwqomishghgyeyq73rxxsqt6zxd7xlqjr3fn2ufejpprnvrra",
        "displayName": "myvault",
        "vaultId": "ocid1.vault.oc1.iad.bzqr2gwdaaeug.abuwcljstlp64k7rsx7rqbsikuj3fgkzkftxdpalow4u3tulr4mlaeqpau3a"
      }
    }
  ]

Examples vault-reactive and vault-cdi have been updated to include the new health check.

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas removed the wip label Aug 20, 2021
@spericas spericas added this to the 2.4.0 milestone Aug 20, 2021
@spericas spericas changed the title WIP: Health check for OCI vaults Health check for OCI vaults Aug 20, 2021
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have just raised one question.

@arjav-desai arjav-desai self-requested a review August 26, 2021 14:09
Copy link
Member

@arjav-desai arjav-desai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spericas spericas merged commit 2381396 into helidon-io:master Aug 26, 2021
@spericas spericas mentioned this pull request Aug 26, 2021
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants