MicroProfile Config 3.0 #3644
MicroProfile Config 3.0 #3644
Conversation
| return findConfigValue(key) | ||
| .orElseGet(() -> new ConfigValueImpl(key, null, null, null, 0)); | ||
| } | ||
| return findConfigValue("%" + configProfile + "." + key) |
There was a problem hiding this comment.
Is the need for all this String concatenation required by the spec for profiles? Seems like not the fastest option
There was a problem hiding this comment.
The specification for profile requires that you first attempt to find the configuration value by the config profile prefix (which implies string concatenation), and then (if not found) you use the original key.
There was a problem hiding this comment.
Caching is not an option, as MP Config requires the values to be always requested from config source(s)
config/config-mp/src/main/java/io/helidon/config/mp/MpConfigImpl.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/main/java/io/helidon/microprofile/config/FieldTypes.java
Outdated
Show resolved
Hide resolved
microprofile/config/src/main/java/io/helidon/microprofile/config/DefaultConfigValue.java
Outdated
Show resolved
Hide resolved
| @@ -492,7 +498,12 @@ public Config build() { | |||
|
|
|||
| // nope, return the result | |||
| if (configuredProfile == null) { | |||
| LOGGER.fine("Built MP config with no profile"); | |||
There was a problem hiding this comment.
if (LOGGER.isLoggable(Level.FINEST)) {
There was a problem hiding this comment.
Not needed (also it is fine not finest). If the string is a constant, there is not much overhead doing it this way. The guarding of logs statements should only be used when passing variables to output
Implementation of MP Config
Enabled TCK for Config
Fixed all related tests
Resolves #2640