Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated doc for FT MP using new template #4438

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Updated doc for FT MP using new template #4438

merged 5 commits into from
Jun 29, 2022

Conversation

spericas
Copy link
Member

@spericas spericas commented Jun 27, 2022 •
edited
Loading

Updated doc for FT MP using new template. Issue #4210.

Signed-off-by: Santiago Pericasgeertsen santiago.pericasgeertsen@oracle.com

@spericas
Updated doc for FT MP using new template.
a50421b 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added the 3.x Issues for 3.x version branch label Jun 27, 2022
@spericas spericas added this to the 3.0.0 milestone Jun 27, 2022
@spericas spericas self-assigned this Jun 27, 2022
ljamen
ljamen reviewed Jun 27, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - note to myself for review.

docs/mp/faulttolerance/01_overview.adoc Show resolved Hide resolved
dalexandrov
dalexandrov previously approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@dalexandrov dalexandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few minor fixes :)

docs/mp/faulttolerance/01_overview.adoc Show resolved Hide resolved
docs/mp/faulttolerance/01_overview.adoc Outdated Show resolved Hide resolved
docs/mp/faulttolerance/01_overview.adoc Show resolved Hide resolved
@spericas
Removed link to SE docs, added link to Javadocs.
2373087 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
tjquinno
tjquinno requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for one broken link.

docs/mp/faulttolerance/01_overview.adoc Outdated Show resolved Hide resolved
@spericas
Fixed typo in link.
9e3609d 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas
Provided better link to spec document.
bb7f7a8 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested review from tjquinno and ljamen June 29, 2022 13:53
ljamen
ljamen reviewed Jun 29, 2022
View reviewed changes
Copy link
Contributor

@ljamen ljamen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small updates.
Change to half-open state throughout.

docs/mp/faulttolerance/01_overview.adoc Outdated Show resolved Hide resolved
docs/mp/faulttolerance/01_overview.adoc Outdated Show resolved Hide resolved
tjquinno
tjquinno previously approved these changes Jun 29, 2022
View reviewed changes
@tjquinno tjquinno dismissed their stale review June 29, 2022 15:04

Didn't notice Lisa's suggestions.

@spericas
Fixed typos.
a8a15a2 
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas requested review from ljamen and tjquinno June 29, 2022 15:43
@spericas spericas merged commit 2bbcb32 into helidon-io:master Jun 29, 2022
@spericas spericas mentioned this pull request Jun 29, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

@dalexandrov dalexandrov Awaiting requested review from dalexandrov

@ljamen ljamen Awaiting requested review from ljamen

Assignees

@spericas spericas

Labels
3.x Issues for 3.x version branch
Projects
Backlog
Archived in project
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@spericas @dalexandrov @tjquinno @ljamen