Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helidon MP Tutorial #942

Merged
merged 26 commits into from
Sep 4, 2019
Merged

Helidon MP Tutorial #942

merged 26 commits into from
Sep 4, 2019

Conversation

markxnelson
Copy link
Contributor

Provides step by step instructions on how to create an Helidon MP
application from scratch, without using the Maven archetypes.
Along the way it explains what things are, how they are used, and
provides links to more detailed information.

Covers how to use Helidon and MicroProfile configuration, logging,
metrics, and health checks. It also demonstrated how to package
the application in a Docker image and run it in Kubernetes.

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>

Provides step by step instructions on how to create an Helidon MP
application from scratch, without using the Maven archetypes.
Along the way it explains what things are, how they are used, and
provides links to more detailed information.

Covers how to use Helidon and MicroProfile configuration, logging,
metrics, and health checks. It also demonstrated how to package
the application in a Docker image and run it in Kubernetes.

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
@tomas-langer
Copy link
Member

Also please use {helidon-version} as a placeholder for version of Helidon - e.g. do not use an explicit version (such as 1.2.0 you use)

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Outdated Show resolved Hide resolved
docs/src/main/docs/guides/91_mp-tutorial.adoc Show resolved Hide resolved
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
m0mus
m0mus previously approved these changes Aug 27, 2019
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
barchetta
barchetta previously approved these changes Aug 28, 2019
tomas-langer
tomas-langer previously approved these changes Aug 29, 2019
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

m0mus
m0mus previously approved these changes Aug 29, 2019
Copy link
Contributor

@m0mus m0mus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

specific code in it. There are many JAX-RS tutorials available if you
want to learn more about this kind of application.

A main class is also required to start up the server and run the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A main class should not be required. In fact, this class has Helidon-specific imports. It's OK if we want to include a main, but needs a clarification IMO.

ljnelson
ljnelson previously approved these changes Aug 30, 2019
@barchetta barchetta dismissed stale reviews from ljnelson, m0mus, tomas-langer, and themself via 57f890c September 4, 2019 21:02
@barchetta barchetta merged commit c867f44 into helidon-io:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants