Support admin port in openapi #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metrics MP services into one place; add use of that to OpenAPI MP service
…in-openapi Get concurrent changes to master
romain-grecourt
previously approved these changes
Sep 7, 2019
tomas-langer
requested changes
Sep 8, 2019
microprofile/server/src/main/java/io/helidon/microprofile/server/RoutingBuilders.java
Outdated
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/RoutingBuilders.java
Show resolved
Hide resolved
microprofile/metrics/src/main/java/io/helidon/microprofile/metrics/MetricsMpService.java
Outdated
Show resolved
Hide resolved
microprofile/server/src/main/java/io/helidon/microprofile/server/RoutingBuilders.java
Outdated
Show resolved
Hide resolved
…lass; rename the factory methods to create... instead of new...; change the accessor method names for clarity
tomas-langer
approved these changes
Sep 10, 2019
| ConfigValue<String> routingNameConfig = metricsConfig.get("routing").asString(); | ||
| Routing.Builder defaultRouting = serviceContext.serverRoutingBuilder(); | ||
| RoutingBuilders routingBuilders = RoutingBuilders.create( | ||
| serviceContext, metricsConfig); |
There was a problem hiding this comment.
Strange formatting - this should be on the same line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #893
This PR refactors the nearly-duplicate logic in the metrics and health MP services into a new interface and references it from those services and from OpenAPI.