From 42c7c9c76ec0694f9c24eab1d716e3f5b5613c56 Mon Sep 17 00:00:00 2001 From: bartowl Date: Thu, 17 Aug 2023 16:16:55 +0200 Subject: [PATCH] add nolog for password fields --- changelogs/fragments/375_nolog_modules.yml | 3 +++ plugins/modules/oracle_awr | 2 +- plugins/modules/oracle_facts | 2 +- plugins/modules/oracle_job | 2 +- plugins/modules/oracle_jobclass | 2 +- plugins/modules/oracle_jobschedule | 2 +- plugins/modules/oracle_jobwindow | 2 +- plugins/modules/oracle_ldapuser | 6 +++--- plugins/modules/oracle_rsrc_consgroup | 2 +- 9 files changed, 13 insertions(+), 10 deletions(-) create mode 100644 changelogs/fragments/375_nolog_modules.yml diff --git a/changelogs/fragments/375_nolog_modules.yml b/changelogs/fragments/375_nolog_modules.yml new file mode 100644 index 000000000..c7e7a98ca --- /dev/null +++ b/changelogs/fragments/375_nolog_modules.yml @@ -0,0 +1,3 @@ +--- +minor_changes: + - "oradb_facts: list of exported attributes is now configurable (oravirt#375)" \ No newline at end of file diff --git a/plugins/modules/oracle_awr b/plugins/modules/oracle_awr index 8553fe7b6..bcc0ef9f9 100644 --- a/plugins/modules/oracle_awr +++ b/plugins/modules/oracle_awr @@ -112,7 +112,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), snapshot_interval_min = dict(default=60, type='int', aliases=['interval']), snapshot_retention_days = dict(default=8, type='int', aliases=['retention']) diff --git a/plugins/modules/oracle_facts b/plugins/modules/oracle_facts index 2c5729c47..9cd1030e1 100644 --- a/plugins/modules/oracle_facts +++ b/plugins/modules/oracle_facts @@ -101,7 +101,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]) ), supports_check_mode=True diff --git a/plugins/modules/oracle_job b/plugins/modules/oracle_job index 108c7d355..4a9efc032 100644 --- a/plugins/modules/oracle_job +++ b/plugins/modules/oracle_job @@ -366,7 +366,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), state = dict(default="present", choices=["present", "absent"]), enabled = dict(default=True, type='bool'), diff --git a/plugins/modules/oracle_jobclass b/plugins/modules/oracle_jobclass index 9f6805b3d..b3b2aad57 100644 --- a/plugins/modules/oracle_jobclass +++ b/plugins/modules/oracle_jobclass @@ -132,7 +132,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), state = dict(default="present", choices=["present", "absent"]), name = dict(required=True), diff --git a/plugins/modules/oracle_jobschedule b/plugins/modules/oracle_jobschedule index ad0260917..8822c7338 100644 --- a/plugins/modules/oracle_jobschedule +++ b/plugins/modules/oracle_jobschedule @@ -127,7 +127,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), state = dict(default="present", choices=["present", "absent"]), name = dict(required=True), diff --git a/plugins/modules/oracle_jobwindow b/plugins/modules/oracle_jobwindow index 53f10b563..137b6daf8 100644 --- a/plugins/modules/oracle_jobwindow +++ b/plugins/modules/oracle_jobwindow @@ -146,7 +146,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), state = dict(default="enabled", choices=["absent","enabled","disabled"]), name = dict(required=True, aliases=["window_name"]), diff --git a/plugins/modules/oracle_ldapuser b/plugins/modules/oracle_ldapuser index 7bee0b833..14f6f246f 100644 --- a/plugins/modules/oracle_ldapuser +++ b/plugins/modules/oracle_ldapuser @@ -220,17 +220,17 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), user_default_tablespace = dict(default='USERS'), user_quota_on_default_tbs_mb = dict(default=None, type='int'), # None is unlimited user_temp_tablespace = dict(default='TEMP'), user_profile = dict(default='LDAP_USER'), - user_default_password = dict(default=None), # None means EXTERNAL + user_default_password = dict(default=None, no_log=True), # None means EXTERNAL user_grants = dict(default=['create session'], type='list'), ldap_connect = dict(required=True), ldap_binddn = dict(required=True), - ldap_bindpassword = dict(required=True), + ldap_bindpassword = dict(required=True, no_log=True), ldap_user_basedn = dict(required=True), ldap_user_subtree = dict(default=True, type='bool'), ldap_user_filter = dict(default='(objectClass=user)'), diff --git a/plugins/modules/oracle_rsrc_consgroup b/plugins/modules/oracle_rsrc_consgroup index 9dec2d4cb..700d274dd 100644 --- a/plugins/modules/oracle_rsrc_consgroup +++ b/plugins/modules/oracle_rsrc_consgroup @@ -267,7 +267,7 @@ def main(): port = dict(default=1521, type='int'), service_name = dict(required=True), user = dict(required=False), - password = dict(required=False), + password = dict(required=False, no_log=True), mode = dict(default='normal', choices=["normal","sysdba"]), state = dict(default="present", choices=["present", "absent"]), name = dict(required=True),