Skip to content
This repository has been archived by the owner on Sep 30, 2023. It is now read-only.

Log.difference behaviour #230

Open
latenssi opened this issue Jan 29, 2019 · 0 comments
Open

Log.difference behaviour #230

latenssi opened this issue Jan 29, 2019 · 0 comments

Comments

@latenssi
Copy link

latenssi commented Jan 29, 2019

Referring to this line of code: log.js#L581

When this is using a._headsIndex I get an empty log back when comparing 2 logs with same head but the other one having a longer history (more entries loaded from local filesystem). If I monkeypatch (as seen here) this to use a._entryIndex I get back what I would l logically expect (log with entries which are in the other but not in the other).

@thiagodelgado111 Would you consider the change I made a sound one and should we implement it in ipfs-log or am I missing something?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant