Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dusk v6 release #48

Closed
barryvdh opened this issue Aug 28, 2020 · 5 comments
Closed

Dusk v6 release #48

barryvdh opened this issue Aug 28, 2020 · 5 comments

Comments

@barryvdh
Copy link
Contributor

barryvdh commented Aug 28, 2020 •
edited
Loading

Is is possible to prepare a Dusk 6 release branch, for Laravel 8? So we can start testing Laravel 8 packages before the release?
Thanks!
@barryvdh barryvdh mentioned this issue Aug 28, 2020
Merged
@crynobone
Copy link
Member

Sure, but dev-master or "orchestra/testbench-dusk": "^6.0" right now should allow tests against Laravel 8.

@barryvdh
Copy link
Contributor Author

Hmm, I tried that in barryvdh/laravel-debugbar#1097 but it fails (eg. in https://github.com/barryvdh/laravel-debugbar/pull/1097/checks?check_run_id=1040482927 )

Not really sure what is conflicting then

@crynobone
Copy link
Member

crynobone commented Aug 28, 2020 •
edited
Loading

Just made a commit to use laravel/nova ^6.5 instead of dev-master. Should work now.

@barryvdh
Copy link
Contributor Author

Thanks, it works now :)

@crynobone
Copy link
Member

Welcome, thanks for letting me know about this.

Proper branch should be available soon.

@bjuppa bjuppa mentioned this issue Sep 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crynobone @barryvdh