-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Inscriptions off by one] Unbound inscription - false positive #2202
Comments
I meant, the transaction is not perfectly fine, but the resulting inscription should have been marked as cursed, not unbound. |
May be a sat that has been reinscribed more than once. |
A reinscription would lead to a |
In ord 0.6.x so far reinscriptions are unbound and cursed. Unless the inscription in question would previously (0.5.x) not have been a reinscription - then it is not cursed. This was to address #2149 |
This is the inscription that causes 0.5.x and 0.6.x to disagree on inscription numbers:
0.5.x doesn't accept it and 0.6.x does. |
Confirmed reinscription with logging code from https://github.com/veryordinally/ord/tree/issue-2202
|
The concept of
|
So as suspected the issue is that this is caused by the code to address #2149 - this inscription is supposed to be recognized, but needs to be assigned a negative number. |
ord 0.6.0 recognizes reinscriptions (as cursed), but makes them unbound. Except for the special case #2149 where they are assigned a positive number. That logic triggers here wrongly, and causes the bug. I would say this is clearly a bug in ord, and we should fix it quickly, and reindex ordinals.com
I would strongly vote for 1. in this instance. @raphjaph thoughts? |
Also note that the behavior implemented and observed is not what is being described in #2149. |
Plan is for @raphjaph and me to work on a fix tomorrow morning, and make a new release, and rebuild the ordinals.com index from the affected inscription number 12,649,108 upwards. |
Sat output is not quite right:
|
Results from indexing: |
So if every re-inscribed inscription is unbounded and cursed .Every re-inscribe will cause a re-index right ? Don't know if my understanding is correct And Curious how this can be maintained more easily ... Imagine someone re inscribe something everyday 🧿🧿🧿 |
Sorry for cryptic updates - we're still in the midst of debugging, but I think I have it now. Will write up a detailed explanation here once confirmed. Reinscriptions will not cause re-indexes! We just had a really curious combination of edge cases here. |
Wow realy love to learn more on the coming updates 🧿 |
I am seeing quite some divergences in inscription number among indexers: 13273849: https://bestinslot.xyz/ordinals/inscription/1372e603f06aaeb88bc3069fdf0a135647d79aa347156973b227511f69689731i0 Any chance this relates to the upgrade/fix? |
Indexing comparison file at http://ordinals.tel:8181/inscription_number_to_id-0.6.3-rc.tsv.gz |
It looks like the latest version of ord is introducing a regression, when handling unbound inscriptions:
https://ordinals.com/inscription/207322afdcca902cb36aeb674214dc5f80f9593f12c1de57830ad33adae46a0ai0
seems perfectly fine, and yet is being marked as unbound.
What went wrong there?
The text was updated successfully, but these errors were encountered: