Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database schema check broken in 0.10.0 #2622

Closed
gmart7t2 opened this issue Nov 2, 2023 · 2 comments
Closed

Database schema check broken in 0.10.0 #2622

gmart7t2 opened this issue Nov 2, 2023 · 2 comments

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Nov 2, 2023

Ord 0.10.0 changed the location in the database that the schema number is stored. See #2541. Before 0.10.0 Schema was the first Statistic enum. In 0.10.0 it's the 9th, and in the current master branch it's the 10th.

It really should be in the same location for every version so we can detect which schema the db was created with.

It's too late now for 0.10.0 but we should put it back to being the first Statistic for 0.10.1 and 0.11.0.

@gmart7t2
Copy link
Contributor Author

gmart7t2 commented Nov 2, 2023

This is the specific change I'm talking about:

Screenshot_20231102_124957_Presearch

@raphjaph
Copy link
Collaborator

raphjaph commented Nov 2, 2023

Thanks, good catch! Made the fix in #2624.

@raphjaph raphjaph closed this as completed Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants