-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jubilee Bounty #2693
Comments
instead of recognizing only the following witness data
it could also support
Example reveal txn not indexed by ord and
|
@felipelincoln This is true, and it would be better! However, it's a marginal improvement, and probably not worth the disruption, and we already knew about it: https://twitter.com/rodarmor/status/1706124168314638538 |
What about ending the envelope in an Example: https://mempool.space/testnet/tx/3d1a2f7bb221d04e585dbe4dd61d77c9809769231ceb0a65ddcd637bd2c926e9 |
Also, what about inserting arbitrary op codes in the middle of an envelope, such as an Example: https://mempool.space/testnet/tx/a194afa2a7de7945fa91ef4a23cc9f8f0a682db70a0f1497033053262de03b3c |
Once |
I think so. Since they aren't executed, I can't think of any particular benefit to recognizing them. |
Of course. Point being that that verification, aimed at bitcoin core, could live inside the else clause. The else clause is not supposed to be part of the envelope; the envelope would simply end in |
True, though I would note that this also breaks when that op code is inside the body, following OP_0. Not sure why somebody would want to put an op code in the body (other than the above mentioned |
I am not super familiar with the development of rollups, but isn't one of the main ideas behind the new rollup work on Bitcoin (utilizing the inscription envelope design) to enable opcodes which would otherwise require a bitcoin soft fork? |
Rollup payloads would probably be just pushbyte opcodes, which contained the rollup scripts, not directly including them in an envelope verbatim. |
Right, but in that case, it doesn't need to be in the else clause at all. It can just be before or after the envelope. Also, this could be done in a backwards compatible way if we wanted to do it later. |
Just out of curiosity, how would the backwards-compatible way work without renumbering? |
Currently, inscriptions with a trailing |
Hm, I feel like I'm missing something. The transaction I linked above, But to be fair, it did have some random stuff inside the else clause ( And it also did not get indexed: https://testnet.ordinals.com/tx/7bb6dfc94905e1aa4568274241d8cc7861ba6acaac81249069bb060ad73edda6 Sorry in advance for being dense! |
Ah, no, of course you're right. The envelope ends with the |
I can submit a PR to fix it – if you think it should be, that is. It's fairly trivial. |
What do you imagine the use-case would be? It would be for associating arbitrary bitcoin script with an inscription, but I'm not sure what that would be useful for. Especially because it has to be executes, so you couldn't include the equivalent of a script pubkey, which is only valid when given additional inputs, or a script witch becomes valid later, for example with a timelock. |
I cannot imagine a scenario where this would actually make sense, considering it's cheaper to do bitcoin-script-related checks outside the envelope. Really the question is merely if it should be considered valid, which is a subjective matter that I probably should not opine on. |
@casey check this tx https://mempool.space/tx/99972873dcd0596c2c81e3ed97704aa3924665a872f9eb9fbb9e1f975703e998 |
Love the find! In a very similar vein, if the envelope is nested inside another OP_IF, should it be detected? I. e.
Example: |
Maybe testnet.ordinals.com just isn't updated yet, because you explicitly mention in your comment it should be detected. EDIT: Ah, it's not merged yet lol, nvm. |
It is November 27th, one day after the bounty deadline, so the Jubilee Bounty has concluded! @ipoh123's find was the first and only qualifying submission, finding a bug in the inscription parser which would cause inscriptions with combinations of Although this did cause some inscriptions to be unrecognized, it doesn't make me worry very much about the Jubilee, since we probably wouldn't have bothered to do another Jubilee based on this find. |
@casey |
@ipoh123 Thank you! And sorry for the delay, we should be able to pay the bounty shortly, no later than Friday of this week. |
@ipoh123 The bounty has been paid out! https://mempool.space/tx/74bd591accfb44167b7799de12778bee93288a590159d09c78cb90184634398a Thank you very much for finding the stuttering curse! 🙇♂️ |
@casey reveived! Thanks!~ |
Currently, there are many desirable ways of making an inscription which results in the inscription being cursed and receiving a negative inscription number. These include multiple inscriptions in a transaction, inscriptions using the pointer field, and inscriptions with metadata larger than 520 bytes. These inscriptions weren't indexed by the first version of ord, so in order to index them while keeping inscription numbers stable, they are assigned negative inscription numbers outside of the positive inscription number sequence.
We are planning, at a future block height, to make new inscriptions which use these features uncursed. This is fancifully termed the Jubilee.
We would like to avoid a situation where, after the Jubilee, we discover new ways to make inscriptions which are desireable, and which cause the inscription to be unrecognized by ord, which might necessitate a second Jubilee, fancifully termed "Jubilee 2: Electric Boogaloo".
To help root out issues before the Jubilee, we are offering a 0.1 BTC bounty to the first person who finds a way to create an inscription which is unrecognized by the current
master
branch version oford
, is desirable to recognize, and which we don't already know about. The bounty runs from today, November 17th, to Sunday November 26th.Please keep in mind that this criteria is highly subjective. We reserve the right to determine what is and isn't desirable to recognize, and what we have already considered. By participating in the bounty, keep in mind that you are relying on our subjective judgement!
Some examples of things which would qualify for the bounty:
Some examples of things which woudln't qualify for the bounty:
Good luck, and happy hunting!
The text was updated successfully, but these errors were encountered: