Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a runes page #3213

Closed
lugondev opened this issue Mar 3, 2024 · 8 comments · Fixed by #3215
Closed

Add a runes page #3213

lugondev opened this issue Mar 3, 2024 · 8 comments · Fixed by #3215

Comments

@lugondev
Copy link
Contributor

lugondev commented Mar 3, 2024

I think we need pagination for runes:

  1. Store data into table NUMBER_TO_RUNE_ID or NUMBER_TO_RUNE_ENTRY
  2. Create endpoint for pagination
@lugondev
Copy link
Contributor Author

lugondev commented Mar 3, 2024

@casey @raphjaph what do you think about it?

@lugondev
Copy link
Contributor Author

lugondev commented Mar 4, 2024

define_table! { NUMBER_TO_RUNE, u64, u128 }

@lugondev
Copy link
Contributor Author

lugondev commented Mar 9, 2024

define_table! { NUMBER_TO_RUNE_INFO, u64, RuneInfoValue }

#[derive(Debug, PartialEq, Copy, Clone, Serialize, Deserialize)]
pub struct RuneInfo {
  pub id: RuneId,
  pub entry: RuneEntry,
}
pub(super) type RuneInfoValue = (
  RuneIdValue,    // rune_id
  RuneEntryValue, // rune_entry
);

@lugondev
Copy link
Contributor Author

lugondev commented Mar 9, 2024

I need the feedback. @casey @raphjaph
If this idea is not necessary, please give me comments.
Thankssss

@raphjaph raphjaph linked a pull request Mar 11, 2024 that will close this issue
@raphjaph
Copy link
Collaborator

Hey, will try to look at this tomorrow!

@raphjaph
Copy link
Collaborator

Left some comments on the PR!

@lugondev
Copy link
Contributor Author

I try to use RUNE_ID_TO_RUNE_ENTRY to query but I dont know how to limit and chunk to pagination.
Please review this issue.

@lugondev
Copy link
Contributor Author

@raphjaph merge latest and fix conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants