Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"wallet resume" should wait for the commit with the most confirmations first #3478

Closed
gmart7t2 opened this issue Apr 7, 2024 · 3 comments · Fixed by #3566
Closed

"wallet resume" should wait for the commit with the most confirmations first #3478

gmart7t2 opened this issue Apr 7, 2024 · 3 comments · Fixed by #3566

Comments

@gmart7t2
Copy link
Contributor

gmart7t2 commented Apr 7, 2024

ord wallet resume waits for the etchings in alphabetical order. If you have pending etchings for RUNE.A and RUNE.B, and the commit for RUNE A is unconfirmed while the commit for RUNE.B has 6 confirmations, wallet resume will wait for the RUNE.A commit to have 6 confirmations before sending the reveal for RUNE.B.

It would be better if it waited for all of them independently, because if we have 2 etchings with 0 confirmations we don't know which one will get to 6 confirmations first.

@raphjaph
Copy link
Collaborator

raphjaph commented Apr 7, 2024

Agreed, should probably just start different threads for each. The inital design had that but wanted to make a release so deleted it.

@siddharth0a
Copy link

good issue I will try it

@gmart7t2
Copy link
Contributor Author

No need for multiple threads. Just loop through each pending etch and check whether it has 6 confs yet. Then wait 5 seconds and try again, until they are all gone

@casey casey removed the status in Tracker Apr 15, 2024
@casey casey moved this to To Do in Tracker Apr 15, 2024
@raphjaph raphjaph moved this from To Do to In Progress in Tracker Apr 16, 2024
@raphjaph raphjaph moved this from In Progress to Ready for Review in Tracker Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants