GeoServer Plugin

[weskamm]

We need to get the GeoServer Plugin running better and become more visible at all.
Therefore i did a quick test of the current state.

My current findings.
Tested with latest stable 2.18.2:

Issues:

• open geostyler tab on a rastersymbolizer SLD

  • geostyler does not appear
  • layerpreview does not appear
  • fontsize seems to be changed on the whole page -> bad css?!
  • console throws warns and erros:
    • Warn: @babel/polyfill is loaded more than once
    • Error: Wicket.Ajax: Cannot bind a listener for event "click" on element "idfa" because the element is not in the DOM
  • WFS Data Parser does a describefeature call for a raster style -> leads to errors
    https://github.com/geoserver/geoserver/blob/051d7a91c3dae51e18b71a344f3867687c722b2b/src/community/geostyler/src/main/resources/org/geoserver/wms/web/data/geostyler-init.ftl#L19
  • Error: Uncaught (in promise) Could not parse XML document: TypeError: Cannot read property 'forEach' of undefined

• open geostyler tab on a polygonsymbolizer SLD

  • geostyler appears
  • layerpreview does not appear
  • fontsize seems to be changed on the whole page -> bad css?!
  • console throws warns and erros:
    • Warn: @babel/polyfill is loaded more than once
  • Some Workflow logs to console "onchange" and the SLD body
    see https://github.com/geoserver/geoserver/blob/051d7a91c3dae51e18b71a344f3867687c722b2b/src/community/geostyler/src/main/resources/org/geoserver/wms/web/data/geostyler-init.ftl#L58
  • CSS seems to be bad when entering fullscreen mode, not sure if this related to the plugin or a generic issue (can be also seen on default style tab)

Code needs overall cleanup, linting and update

Ideas:

• Make SLD Editor collapsible? -> Size (height) can become an issue with geostyler and SLD editor shown at the same time

[weskamm]

I will start to fixup the issues mentioned.
Please discuss options / features for better integration and user experience or mention other issues you have found

[jansule]

Additionally, we should get rid of the GeoStyler tab and integrate GeoStyler properly (always above the SLD editor).

Another BIG thing is the proper support for the different SLD versions, as mentioned in geostyler/geostyler-sld-parser#288

[weskamm]

I like the idea of integrating it directly in the default style tab, will have a look at that

[dnlkoch]

Yes, that would be awesome!

[weskamm]

Solution should look something like this, but i am still finding a way solving this in a clean way

[weskamm]

After discussing this on the dev mailinglist i think i can proceed with that idea.
Current state of work can be found here: geoserver/geoserver@master...weskamm:geostylerintegration

[weskamm]

I think an option for "live updating" is a nice idea too!

[weskamm]

Ok, issues have been fixed and current state can be found at
geoserver/geoserver@master...weskamm:geostylerintegration

Needs following PR in geoserver before:
geoserver/geoserver#4779

This is what it looks like:

[KaiVolland]

Looks awesome. Can you switch between the side-by-side view and the below-and-above view?

[weskamm]

yes, side by side is the fullscreen view. i cropped the screenshot no. 1, it contains the menu as usual

[weskamm]

Final PR is out here: geoserver/geoserver#4795