Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM64 builds for M1 macs #103

Closed
joberget opened this issue Aug 17, 2022 · 7 comments
Closed

Support ARM64 builds for M1 macs #103

joberget opened this issue Aug 17, 2022 · 7 comments
Assignees
Labels
feature/request New feature or request

Comments

@joberget
Copy link

Describe the solution you'd like
Builds supporting M1 ARM64 Architecture

@joberget joberget added the feature/request New feature or request label Aug 17, 2022
@joberget
Copy link
Author

joberget commented Aug 17, 2022

Oh I found this through brew, no need to have this opened then. :)

==> Downloading https://ghcr.io/v2/homebrew/core/git-cliff/manifests/0.9.0
######################################################################## 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/git-cliff/blobs/sha256:806d48dcb3356bfb88e6770f4505adde46a7ab2ba0f9e2b1ad0b08be9719e1fd
==> Downloading from https://pkg-containers.githubusercontent.com/ghcr1/blobs/sha256:806d48dcb3356bfb88e6770f4505adde46a7ab2ba0f9e2b1ad0b08be9719e1fd?se=2022-08-17T11%3A45%3A00Z&sig=H2PmJPMkhl8KFOXYgVd%2F4oYSwbeR4%2BVV4vjDsfRZ%2Fwo
######################################################################## 100.0%
==> Pouring git-cliff--0.9.0.arm64_monterey.bottle.tar.gz

@orhun orhun closed this as completed Aug 17, 2022
@h3adache
Copy link

commenting on a closed issue but just wanted to mention that tool sharing using asdf/mise is quite popular for development teams.

Was looking to switch to using git-cliff for changelog generation but ran into this when trying to mise install git-cliff as it uses https://github.com/jylenhof/asdf-git-cliff which tries to pull the releases based on arch.

@orhun
Copy link
Owner

orhun commented Apr 13, 2024

@h3adache it is probably better to report it to the packager? Is there anything that I can do from the builds side?

@h3adache
Copy link

Thanks for the quick response @orhun! It's an issue that can actually be solved by either publishing a release asset for arm64 darwin or fixing the packager to accept ARCH overrides as you mentioned.

@orhun
Copy link
Owner

orhun commented Apr 17, 2024

@h3adache
Copy link

Yes but aarch64 isn't what is returned by uname which is what most tool use when checking arch.

https://github.com/h3adache/asdf-git-cliff/blob/main/lib/utils.bash#L35-L43

@orhun
Copy link
Owner

orhun commented May 1, 2024

You can see the naming convention here: https://github.com/orhun/git-cliff/blob/main/.github/workflows/cd.yml#L36-L131

Changing that would break the other build systems so I suggest fixing that at downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants