Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commit): trim the trailing newline for git2 commits #872

Merged
merged 1 commit into from
Sep 21, 2024

Conversation

orhun
Copy link
Owner

@orhun orhun commented Sep 21, 2024

Description

Now we remove the trailing newline for every commit retrieved from a repository.

Motivation and Context

closes #745

How Has This Been Tested?

cargo test

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.33%. Comparing base (82cc09f) to head (42a48f6).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #872   +/-   ##
=======================================
  Coverage   40.33%   40.33%           
=======================================
  Files          21       21           
  Lines        1664     1664           
=======================================
  Hits          671      671           
  Misses        993      993           
Flag Coverage Δ
unit-tests 40.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit 1cdbbf6 into main Sep 21, 2024
59 of 60 checks passed
@orhun orhun deleted the fix/trim_trailing_newline_from_commit branch September 21, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$ anchor in commit_preprocessors not works
2 participants