Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): add missing --use-branch-tags flag to TS options #874

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

favna
Copy link
Contributor

@favna favna commented Sep 22, 2024

Description

v2.6.0 introduced --use-branch-tags but that flag wasn't added to the TS types. Kinda awkward when the changelog specifically says that TS types are fixed ;)

Motivation and Context

Adding the missing option

How Has This Been Tested?

N.A., types only

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@favna favna requested a review from orhun as a code owner September 22, 2024 09:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.03%. Comparing base (3e479c8) to head (d10c084).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #874      +/-   ##
==========================================
+ Coverage   39.97%   40.03%   +0.06%     
==========================================
  Files          21       21              
  Lines        1674     1674              
==========================================
+ Hits          669      670       +1     
+ Misses       1005     1004       -1     
Flag Coverage Δ
unit-tests 40.03% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit e21fb1d into orhun:main Sep 23, 2024
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants