Allow OCL::logging::Category to be property overriden #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does changing |
|
Yes, it would. |
meyerj
approved these changes
Sep 3, 2021
There was a problem hiding this comment.
LGTM, thanks. It makes sense as-is.
Does changing
debug(), etc., to bevirtualachieve the same thing?
@snrkiwi Do you have a use case where you may want to override debug(message) but not log(DEBUG, message)? I think it would be bad, because then the two could eventually behave differently, although the former should be nothing than a simple convenience helper for the latter, no? You can still adapt the behavior for a specific priority only by using an if statement in the overridden log() function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
OCL::logging::Category::debug(RTT::rt_string const&),info, etc... useslog(log4cpp::Priority, RTT::rt_string const&)so it can be overriden.Closes #91.