Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: replace appendToBody by Teleport #603

Closed
mlmoravek opened this issue Sep 27, 2023 · 0 comments · Fixed by #652
Closed

Feature: replace appendToBody by Teleport #603

mlmoravek opened this issue Sep 27, 2023 · 0 comments · Fixed by #652
Assignees
Labels
enhancement Improvements to existing features and functionality

Comments

@mlmoravek
Copy link
Member

Description

Several components (Autocomplete, Dropdown, Datepicker, DateTimepicker, Timepicker, Tooltip) use an appendToBody feature that allows the component to be attached to the body instead of the actual position.

Vue provides a native Teleport component that allows you to "teleport" a component to another location in the dom. This could be used to provide a simpler and Vue-native implementation of the appendToBody feature.

However, some components could also benefit from having such an appendToBody feature, such as the Modal or Sidebar component.

The teleport feature needs to move the whole component and not just parts of it, because template classes could depend on parent ones, for example menu depends on its wrapper, as jtommy mentioned here #487.

@mlmoravek mlmoravek added the enhancement Improvements to existing features and functionality label Sep 27, 2023
@mlmoravek mlmoravek self-assigned this Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features and functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant