Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update config ClassFunction second parameter from context to props #743

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

mlmoravek
Copy link
Member

Using the composition api, the $data and $computed attributes are no longer available on a component instance.
Therefore they can't be used for the second parameter of the ClassFunction theme config.

Since the ComponentContext then only contains the component props, I pass the props directly as the second parameter of the function.

Proposed Changes

  • update ComponentContext to ComponentProps

@mlmoravek mlmoravek added the bug Something isn't working label Jan 24, 2024
@mlmoravek mlmoravek requested a review from jtommy January 24, 2024 12:03
@mlmoravek mlmoravek self-assigned this Jan 24, 2024
Copy link

netlify bot commented Jan 24, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit d9f6d29
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65b0fc7623421d0008e06ad1
😎 Deploy Preview https://deploy-preview-743--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (da4c7c5) 51.79% compared to head (d9f6d29) 52.17%.

Files Patch % Lines
...ges/oruga-next/src/composables/useComputedClass.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #743      +/-   ##
===========================================
+ Coverage    51.79%   52.17%   +0.37%     
===========================================
  Files           32       32              
  Lines         1392     1382      -10     
  Branches       513      511       -2     
===========================================
  Hits           721      721              
+ Misses         671      661      -10     
Flag Coverage Δ
oruga-next 52.17% <16.66%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants