Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): stickyHeaderClass should not display by default #832

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

whiplashwebb
Copy link
Contributor

Fixes an issue where the table will display stickyHeaderClass when no value is provided for props.stickyHeader.

Proposed Changes

  • Cast props.stickyHeader to bool in tableWrapperClasses

Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit f62863a
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65e5e808ccd3dc000891d6dc
😎 Deploy Preview https://deploy-preview-832--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mlmoravek
Copy link
Member

@whiplashwebb Thanks for finding this bug. Maybe better set the prop default to false?

@mlmoravek mlmoravek added the bug Something isn't working label Mar 2, 2024
@mlmoravek mlmoravek changed the title fix(table): stickyHeaderClass should not display by default fix(table): stickyHeaderClass should not display by default Mar 2, 2024
@whiplashwebb
Copy link
Contributor Author

@mlmoravek I wasn't sure if the prop was intentionally true/false/undefined so that computed seemed safer, but if you think it's safe i like that much better. fixed.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.20%. Comparing base (484cfe8) to head (f62863a).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #832       +/-   ##
===========================================
- Coverage    56.71%   0.20%   -56.51%     
===========================================
  Files           30     108       +78     
  Lines         1511    5293     +3782     
  Branches       544    1921     +1377     
===========================================
- Hits           857      11      -846     
- Misses         654    4167     +3513     
- Partials         0    1115     +1115     
Flag Coverage Δ
oruga-next 0.20% <ø> (-56.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek
Copy link
Member

@whiplashwebb please regenerate the docs. The props section should change and the default false should be added.

@mlmoravek mlmoravek merged commit 09a45a1 into oruga-ui:develop Mar 5, 2024
7 of 9 checks passed
mlmoravek pushed a commit to mlmoravek/oruga that referenced this pull request Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants