-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): stickyHeaderClass
should not display by default
#832
fix(table): stickyHeaderClass
should not display by default
#832
Conversation
✅ Deploy Preview for oruga-documentation-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@whiplashwebb Thanks for finding this bug. Maybe better set the prop default to |
stickyHeaderClass
should not display by default
@mlmoravek I wasn't sure if the prop was intentionally true/false/undefined so that computed seemed safer, but if you think it's safe i like that much better. fixed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #832 +/- ##
===========================================
- Coverage 56.71% 0.20% -56.51%
===========================================
Files 30 108 +78
Lines 1511 5293 +3782
Branches 544 1921 +1377
===========================================
- Hits 857 11 -846
- Misses 654 4167 +3513
- Partials 0 1115 +1115
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@whiplashwebb please regenerate the docs. The props section should change and the default false should be added. |
Fixes an issue where the table will display
stickyHeaderClass
when no value is provided forprops.stickyHeader
.Proposed Changes
props.stickyHeader
to bool intableWrapperClasses