-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[README.md] relationship between go-acc and Go 1.20 GOCOVERDIR feature #47
Comments
Thank you :) Very nice to see that Go finally delivered on this. If it turns out that Go does this correctly, I think we'll just archive this tool here. |
There is also a fix in Go 1.22 which includes coverage in packages without tests: golang/go#24570 Also, you can run And if one has to combine data from multiple runs (I combine both data from unit tests, integration tests, and e2e tests), there is now |
In fact, I think there are some recent issues with Go and coverage and this tool as well. I made a fork of testing repository and added Now, if I run with
And this returns the same:
But the correct values are:
I think go-acc miscounts packages which have no tests. This was fixed in Go 1.22. |
For several years,
go-acc
has me served very well in my admittedly simple case of aggregating coverage data from root as well as a non-root test runs. A big thank-you for your work from a small fish.Now, Go 1.20 is finally another interesting fish in the sea in this respect, with its new feature of aggregating multiple test and integration test runs. Aggregating multiple unit test runs can be achieved using
go test ... -args -test.gocoverdir="GOCOVERDIR"
(as "documented" here) .How does this Go 1.20 feature relate to
go-acc
? Does it now the same or where are differences?Do you think such a feature comparison to be useful to devs either using
go-acc
or thinking about using it?The text was updated successfully, but these errors were encountered: