Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify core group of code reviewers, who approve commits to production #2

Open
HeatherAck opened this issue Jan 3, 2022 · 6 comments

Comments

@HeatherAck
Copy link
Contributor

No description provided.

@HeatherAck HeatherAck changed the title Identify core group of code reviews, who approve commits to production Identify core group of code reviewers, who approve commits to production Jan 3, 2022
@negillett
Copy link
Collaborator

negillett commented Feb 3, 2022

@HeatherAck, will os-climate switch to a paid version of Github (team, enterprise)? Without that, branch protection for repos, which enforces approvals, CODEOWNER review, status checks, etc., before merging, isn't available, AFAIK.

The alternative is, I suppose, to just have limited Write, Maintain, Admin users to restrict use of push/merge to the repo.

cc @erikerlandson

@erikerlandson
Copy link

Our intent has been to make use of OWNERS, see for example:
https://github.com/operate-first/apps/blob/master/OWNERS

These are supposed to interact with sesheta bot, for example:
operate-first/apps#1556

That said, there are likely multiple benefits to switching to paid github acct, and I agree we should look into that

@erikerlandson
Copy link

cc @HumairAK @MichaelClifford

@HeatherAck
Copy link
Contributor Author

os-climate switch to a paid version of Github (team, enterprise)? Without that, branch protection for repos, which enforces approvals, CODEOWNER review, status checks, etc., before merging, isn't available,

@negillett - I created a ticket with LF to upgrade. will keep you posted

@negillett
Copy link
Collaborator

Ah, interesting, @erikerlandson, thanks.

Yeah, GitHub repo branch protection offers quite a bit. A big one for me is forcing commits be submitted via pull requests.

@negillett
Copy link
Collaborator

It seems branch protection may be free for public repos. So, maybe we can wait until golive rather than upgrading the GitHub account, @HeatherAck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants