From fdd951bb19781837e3a6221ff3faf058c0d3d1dd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lars=20G=C3=B6ttgens?= Date: Wed, 13 Sep 2023 17:17:05 +0200 Subject: [PATCH] Remove functions moved to Nemo (Nemocas/Nemo.jl#1519) --- experimental/GModule/GModule.jl | 3 --- src/Rings/AlgClosureFp.jl | 5 ----- 2 files changed, 8 deletions(-) diff --git a/experimental/GModule/GModule.jl b/experimental/GModule/GModule.jl index e7bee895510a..af469c2c8d62 100644 --- a/experimental/GModule/GModule.jl +++ b/experimental/GModule/GModule.jl @@ -1095,9 +1095,6 @@ function hom_base(C::GModule{<:Any, <:AbstractAlgebra.FPModule{nf_elem}}, D::GMo end end -#T this belongs to Nemo and should be moved there -Oscar.nbits(a::QQFieldElem) = nbits(numerator(a)) + nbits(denominator(a)) - function hom_base(C::_T, D::_T) where _T <: GModule{<:Any, <:AbstractAlgebra.FPModule{QQFieldElem}} @assert base_ring(C) == base_ring(D) diff --git a/src/Rings/AlgClosureFp.jl b/src/Rings/AlgClosureFp.jl index 00da1547d415..e044e5e7033c 100644 --- a/src/Rings/AlgClosureFp.jl +++ b/src/Rings/AlgClosureFp.jl @@ -129,11 +129,6 @@ function op(f::Function, a::AlgClosureElem, b::AlgClosureElem) return f(k(ad), k(bd)) end -#T the following belongs to Nemo and should be moved there -function Oscar.embed(k::Nemo.fpField, K::fqPolyRepField) - @assert characteristic(K) == characteristic(k) -end - +(a::AlgClosureElem, b::AlgClosureElem) = AlgClosureElem(op(+, a, b), parent(a)) -(a::AlgClosureElem, b::AlgClosureElem) = AlgClosureElem(op(-, a, b), parent(a)) #TODO: do we really want to support different types here? (implies different parents)