We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In CsvAppender.appendField(final String value)
final char[] valueChars = value.toCharArray(); ... for (final char c : valueChars) {
This is creating a temporary array that is only used to be iterated. It is easy to avoid this:
for (int i = 0; i < value.length(); i++) { final char c = value.charAt(i);
IMO the extra index checks in charAt() weight less than the "new char[length]" impact on GC. Maybe I am wrong.
BTW, thanks for this nice easy to use library!
The text was updated successfully, but these errors were encountered:
You're right. Thanks for pointing this out! Could you provide a pull request?
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
In CsvAppender.appendField(final String value)
This is creating a temporary array that is only used to be iterated. It is easy to avoid this:
IMO the extra index checks in charAt() weight less than the "new char[length]" impact on GC. Maybe I am wrong.
BTW, thanks for this nice easy to use library!
The text was updated successfully, but these errors were encountered: