Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #913

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Update dependencies #913

merged 2 commits into from
Aug 12, 2023

Conversation

jleedev
Copy link
Member

@jleedev jleedev commented Aug 8, 2023

Update sprites parameter (linz/basemaps#2736)

@jleedev
Update dependencies
184708a 
Update sprites parameter (linz/basemaps#2736)
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

PR Preview:

Sprite Sheets:

Sprites 1x
Sprites 2x

@jleedev
Copy link
Member Author

jleedev commented Aug 9, 2023 •
edited
Loading

Could probably use their command line interface instead of the API, I'm sure there's a reason we scripted this, if not a good reason.

Edit: Well, it doesn't allow specifying the output filename, so that would have to change.

ZeLonewolf
ZeLonewolf approved these changes Aug 12, 2023
View reviewed changes
Copy link
Member

@ZeLonewolf ZeLonewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good here and tested on Ubuntu.

@jleedev jleedev merged commit de941c5 into main Aug 12, 2023
4 checks passed
@jleedev jleedev deleted the jleedev/update-sprites branch August 12, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeLonewolf ZeLonewolf ZeLonewolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jleedev @ZeLonewolf