Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flushing pruning heights metadata once it is added to memory #149

Closed
Tracked by #1016
p0mvn opened this issue Mar 22, 2022 · 1 comment
Closed
Tracked by #1016

Investigate flushing pruning heights metadata once it is added to memory #149

p0mvn opened this issue Mar 22, 2022 · 1 comment

Comments

@p0mvn
Copy link
Member

p0mvn commented Mar 22, 2022 •
edited
Loading

Context

We would like to investigate if it makes sense to flush pruning metadata to disk once it is added to memory. The concern is that if the node halts or crashess, the pruning heights are lost. As a result, these are never removed from the disk.

Originally posted by @ValarDragon in #140 (comment)

Acceptance Criteria

  • Investigate if it is possible to pollute the disk with the current design
  • If yes, create a PR with the fix
  • Additional unit tests
@p0mvn p0mvn moved this to 🔍 Needs Review in Osmosis Chain Development Mar 22, 2022
@p0mvn p0mvn moved this from 🔍 Needs Review to 🕒 Todo in Osmosis Chain Development Mar 22, 2022
@p0mvn p0mvn added the frog label Mar 22, 2022
This was referenced Mar 22, 2022
Merged
Closed
@p0mvn p0mvn moved this from 🕒 Todo to 🔍 Needs Review in Osmosis Chain Development Mar 24, 2022
@p0mvn p0mvn added T:Task ⚙️ A task belongs to an epic frog and removed frog T:Task ⚙️ A task belongs to an epic labels Mar 24, 2022
@p0mvn p0mvn mentioned this issue Mar 26, 2022
Closed
14 tasks
@p0mvn p0mvn moved this from 🔍 Needs Review to 🕒 Todo in Osmosis Chain Development Mar 29, 2022
@ValarDragon ValarDragon removed the frog label Apr 4, 2022
This was referenced Apr 12, 2022
Merged
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Apr 25, 2022

This was merged, closing

@p0mvn p0mvn closed this as completed Apr 25, 2022
Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ValarDragon @p0mvn