Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade 99designs/keyring to remove build warnings on MacOS 12 #1265

Closed
jlbit opened this issue Apr 16, 2022 · 3 comments · Fixed by #1266
Closed

upgrade 99designs/keyring to remove build warnings on MacOS 12 #1265

jlbit opened this issue Apr 16, 2022 · 3 comments · Fixed by #1266

Comments

@jlbit
Copy link
Contributor

jlbit commented Apr 16, 2022

Warnings below, when build on macos, is from 99designs/keyring . We should remove the compiler warnings on macos to reduce noise.

cgo-gcc-prolog:81:11: warning: 'SecKeychainCreate' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:301:10: note: 'SecKeychainCreate' has been explicitly marked deprecated here
cgo-gcc-prolog:139:11: warning: 'SecKeychainLock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:357:10: note: 'SecKeychainLock' has been explicitly marked deprecated here
cgo-gcc-prolog:159:11: warning: 'SecKeychainOpen' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:287:10: note: 'SecKeychainOpen' has been explicitly marked deprecated here
cgo-gcc-prolog:183:11: warning: 'SecKeychainUnlock' is deprecated: first deprecated in macOS 12.0 - Custom keychain management is no longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/Security.framework/Headers/SecKeychain.h:347:10: note: 'SecKeychainUnlock' has been explicitly marked deprecated here
cgo-gcc-prolog:203:11: warning: 'SecTrustedApplicationCreateFromPath' is deprecated: first deprecated in macOS 10.15 - No longer supported [-Wdeprecated-declarations]
/Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/System/Library/Frameworks/Security.framework/Headers/SecTrustedApplication.h:59:10: note: 'SecTrustedApplicationCreateFromPath' has been explicitly marked deprecated here
@daniel-farina daniel-farina moved this to 🔍 Needs Review in Osmosis Chain Development Apr 16, 2022
@jlbit jlbit changed the title surpress build warnings caused by 99designs/keyring remove build warnings caused by 99designs/keyring Apr 16, 2022
@jlbit jlbit changed the title remove build warnings caused by 99designs/keyring upgrade 99designs/keyring to remove build warnings on mac Apr 16, 2022
@jlbit
Copy link
Contributor Author

jlbit commented Apr 16, 2022

there's a reference in Apache Pulsar on fixing it by upgrading keyring apache/pulsar-client-go#719

@jlbit
Copy link
Contributor Author

jlbit commented Apr 16, 2022

fyi, warning screenshot

image

@jlbit jlbit changed the title upgrade 99designs/keyring to remove build warnings on mac upgrade 99designs/keyring to remove build warnings on MacOS 12 Apr 16, 2022
Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Apr 18, 2022
@alexanderbez
Copy link
Contributor

Yes, these have been around for ages. There is nothing we can do directly. These come from the keyring dep. If there is an updated version that handles these deprecated APIs, we should update to that. But there doesn't seem to be a new update.

Are you proposing something else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants